Conversation
lfrancke
left a comment
There was a problem hiding this comment.
LGTM code-wise but maybe there was some intention here that I'm missing
sbernauer
left a comment
There was a problem hiding this comment.
Just for the record:
I only added status.service back than because the docs state it's required in https://www.openpolicyagent.org/docs/configuration#status.
Looks like the docs are wrong.
But anyway, we even added a metrics assertion to the smoke test in that PR, so as long as the test passes I don't care to be honest.
Checked with @sbernauer:
|
|
Could you add a release note for this bug please? Previously, |
|
Looks like the release notes are on the issue: #798 (comment) |
Description
Fixes #798.
Status updates are currently sent to prometheus (correct) and the bundle-builder service, which exposes a status endpoint, but does not offer one to POST to. This has been removed.
The config now changes from
{ ... "status": { "service": "stackable" "prometheus": true } }to
{ ... "status": { "prometheus": true } }and log outputs showing previously
now show
Jenins 🟢 https://testing.stackable.tech/job/opa-operator-it-custom/36
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker